Introduces type aliases for all the classes.
Will remove type checking from the provider.
n/a
We have an example in this project and can run acceptance tests against it. Will it work?
Turning on puppet-lint datatype warnings shows we are missing "some" stuff here. I would start gradually working on fixing all of that, if someone wants to contribute or has some input, feel free.
We noticed that your Puppet module includes Puppet 3.x function and created this
pull request to help you get started porting them to the new API.
The Puppet function API has a long history and many people in the ecosystem,
including you, took advantage of this API to extend Puppet to do some really
cool things. Unfortunately the original function API had many critical
limitations, and so Puppet introduced a new and improved API with Puppet 4.x.
Each modern Puppet 4.x function is just a little faster and just a little safer
to use, meaning that as we all port our functions over, compilation times across
the ecosystem will get more and more performant. Modern Puppet 4.x functions
have improved thread safety, memory management, and load time. Even more
importantly, they’re isolated to the environment they’re loaded from.
And as a developer, you'll see benefits like namespaced function signatures,
automatic data type checking, multiple dispatches allowing you to easily handle
different kinds of function invocations, and vastly improved code reuse.
This pull request was autogenerated and the ported functions do not yet take
advantage of the data type checking or multiple dispatches. You will want to
finish the port by making those changes and adding any documentation updates.
See this tutorial for more information.
While you're at it, double check to see if there are any functions that couldn't
be automatically ported and update them yourself.
To be extra cautious about losing data, this pull request did NOT delete the
legacy function files, so when you're satisfied with the new functions, don't
forget to delete the legacy code!
If this repo is a fork, when you're all done, you might consider contributing
your work upstream.
If you have any questions, feel free to ping me in this PR, or stop by the
Puppet Community Slack to chat. And thanks so much
for being part of our vibrant community of developers!
modulesync 5.4.0
Within /etc/bareos/bareos-dir.d/director/bareos-dir.conf
, Heartbeat Interval
accepts a value of an integer E.G 60
. However, when attempting to set a value of 60 within the bareos director configuration, the below error is shown during rspec testing
ruby
Value '60' does not match regex (?i-mx:^(\d+|(\d+\W+(seconds|sec|s|minutes|min|hours|h|days|d|weeks|w|months|m|quarters|q|years|y)\W*)+)$)
puppet
class { 'bareos::director::director':
heartbeat_interval => 60
...
}
Where 60 is a valid value for the bareos-dir.conf
heartbeat_interval. The values matched by Puppet's timestamp will not work here.
Fixing issue #144 by adding runonincomingconnectinterval to job and jobdef resource.
Fixes #144
<!--
Thank you for contributing to this project!
-->
<!--
Replace this comment with a description of your pull request.
-->
<!--
Replace this comment with the list of issues or n/a.
Use format:
Fixes #123
Fixes #124
-->
Starting with Bareos 23, the Db Driver
parameter is no longer accepted. It has been deprecated for some time. If the parameter exists, the director service won't start.
This PR makes the parameter optional. The docs at the top of the file already say it isn't required.
```
```
Add Bareos Version 22 support and the possibility to add the bareos user to other groups.
Add Bareos Version 23 support (and Bareos Version 22 and the possibility to add the bareos user to other groups)
(this PR extends PR #129, which can be closed)
<!--
Thank you for contributing to this project!
-->
Support Debian 11
<!--
Replace this comment with the list of issues or n/a.
Use format:
Fixes #123
Fixes #124
-->