On MR #27 Hiera lookup started using cron::job::XXX
which also turned around and used create_resrouces('cron::job::XXX'
.
These resources were not in the job directory. I've moved them there. I can only assume that these were lookups were changed due to puppet4's new parameters and having hourly, month, etc were giving warnings as parameters to the cron class.
modulesync 5.4.0
The environment
option does not support sensitive value. I would like to put http_proxy=http://user:password@example.com:3128
in an environment variable, but the content is displayed in cleartext in the log.
This PR allow to define an environment
content as sensitive as followed:
puppet
cron::job { 'example' :
environment => [
Sensitive('http_proxy=http://user:password@example.com:3128'),
'PATH=/usr/bin',
],
command => 'sleep 10',
}
same for cron::job::multiple
There was validation in the erb
template about the environment
variables, and funky .join(\n).split(\n)
but I think it is no longer necessary. The content is validated by puppet directly on the call to cron::job
. Is this behavior a remnant of old puppet when there was no types?
I also removed the environment
variable in the cron::job::multiple::jobs
array, as it was not defined in the old erb
, and kept the same behavior for the epp
.
Feel free to raise concern if you think my assumptions were wrong