modulesync 2.12.0

This is useful on production Jenkins masters where non-scheduled restarts are
dangerous. Unit file changes and user changes that happen before tha package is
installed are not affected.

It's required to support escaping spaces in JENKINSJAVACMD, JENKINSJAVAOPTIONS, JENKINSHOME and JENKINSWAR variables.

For example, it's impossible to set hudson.model.DirectoryBrowserSupport.CSP without this, since CSP policy has to contain spaces, and escaping spaces wasn't possible in JENKINS_JAVA_OPTS.

<!--
Thank you for contributing to this project!

• This project has a Contributor Code of Conduct: https://voxpupuli.org/coc/
• Please check that here is no existing issue or PR that addresses your problem.
• Our vulnerabilities reporting process is at https://voxpupuli.org/security/

-->

Pull Request (PR) description

Allow Java System Properties that may contain spaces as options parameters, like -Dhudson.model.DirectoryBrowserSupport.CSP="sandbox allow-same-origin"

This Pull Request (PR) fixes the following issues

Fixes #927

Retries is only used by the CLI providers. Puppet itself also provides retry functionality. This avoids the need to ensure a gem is installed in the right environment, which may not even work if it's a disconnected environment.

This does ignore a parameter for the maximum time to sleep. I'm looking for feedback on how to best deal with this.

…t runs

<!--
Thank you for contributing to this project!

• This project has a Contributor Code of Conduct: https://voxpupuli.org/coc/
• Please check that here is no existing issue or PR that addresses your problem.
• Our vulnerabilities reporting process is at https://voxpupuli.org/security/

-->

Pull Request (PR) description

Passes credentials to jenkins-cli as environement variables by default so passwords aren't visible in the output of ps during puppet agent runs.

This Pull Request (PR) fixes the following issues

Not sure if this has an associated issue

Pull Request (PR) description

This change removes the start up script for macOS and moves the arguments to the plist template.

```
jenkins_exec{ 'job-dsl security':
script => @(END)
import jenkins.model.*

def j = Jenkins.getInstance()
def jobDsl = j.getDescriptor("javaposse.jobdsl.plugin.GlobalJobDslSecurityConfiguration")
jobDsl.setUseScriptSecurity(false)
END
}
```

As of Jenkins 2.176.2 detached plugins were taking precedence over specified plugins due to a fix that was introduced for docker: https://issues.jenkins-ci.org/browse/JENKINS-57528.

The fix in Jenkins ensured stricter processing of plugins. the module was installing plugins as .hpi files where Jenkins expects them to be .jpi files.

This problem was highlighted in https://github.com/voxpupuli/puppet-jenkins/issues/926.

<!--
Thank you for contributing to this project!

• This project has a Contributor Code of Conduct: https://voxpupuli.org/coc/
• Please check that here is no existing issue or PR that addresses your problem.
• Our vulnerabilities reporting process is at https://voxpupuli.org/security/

-->

Pull Request (PR) description

<!--
Replace this comment with a description of your pull request.
-->

This Pull Request (PR) fixes the following issues

<!--
Replace this comment with the list of issues or n/a.
Use format:
Fixes #123
Fixes #124
-->

Solves #939

Change code ordering to work with Ubuntu 18.04 and add new upstream gpg key from Jenkins

Fixes

920

971

This implementation is broken and as preparation for 3.0.0 the code base is being reduced to working versions. If this is desired by users, a working patch should be provided.

I tried to get it to work, but I couldn't get it to work quickly. It looks like you can no longer get the private data.