GitHub puppet-msoffice
5
5
20
puppet module to manage Microsoft Office on Windows (2003-2013)

Metadata Valid
No translation
Correct Puppet Version Range
Supported Puppet version range is %{PUPPET_VERSION_RANGE}
With Puppet Version Range
Puppet version range is present in requirements in metadata.json
With Operatingsystem Support
No translation
In Modulesync Repo
No translation
In Plumbing
Is in plumbing
Has Secrets
Has a .sync.yml file
Synced
Has a .msync.yml file
Latest Modulesync
No translation
Has Modulesync
Is present in voxpupuli/modulesync_config/managed_modules.yml
Released
Is in modulesync_config and in forge releases.
Reference Dot Md
The repository has a REFERENCE.md. It needs to be generated / puppet-strings documentation is missing.

Open Pull Requests

Update params.pp
bug
tests-fail

Fixes following errors when installing Office 2010

change from 'notrun' to ['0'] failed: '"\foo\bar\OFFICE14\Standard\x86\setup.exe" /modify Standardr /config "C:\Windows\Temp\office_config.xml"' returned 30066 instead of one of [0]

Failed to call refresh: '"\foo\bar\OFFICE14\Standard\x86\setup.exe" /modify Standardr /config "C:\Windows\Temp\office_config.xml"' returned 30066 instead of one of [0]

<!--
Thank you for contributing to this project!

-->

Pull Request (PR) description

<!--
Fixes following errors when installing Office 2010

change from 'notrun' to ['0'] failed: '"\foo\bar\OFFICE14\Standard\x86\setup.exe" /modify Standardr /config "C:\Windows\Temp\office_config.xml"' returned 30066 instead of one of [0]

Failed to call refresh: '"\foo\bar\OFFICE14\Standard\x86\setup.exe" /modify Standardr /config "C:\Windows\Temp\office_config.xml"' returned 30066 instead of one of [0]
-->

This Pull Request (PR) fixes the following issues

<!--
Replace this comment with the list of issues or n/a.
Use format:
Fixes #123
Fixes #124
-->

Address the local Administrators group by its well-known SID rather than by name
tests-fail

Names of security objects built into Windows depend on the installation-time language. For example on a German system the "local administrators" group is called Administratoren rather than Administrators, causing puppet-msoffice to fail because being unable to set the correct owner group on office_config.xml. To make things worse, once set those names cannot be modified even when the default OS language is changed - if you want to rename Administratoren to Administrators you have to reinstall Windows.

Luckily, Puppet now understands Windows security identifiers and there is a well-known SID corresponding to Administrators regardless of the language used. Change group => 'Administrators' to group => 'S-1-5-32-544' and it will work regardless of whether your copy of Windows has been installed in English, German, Swahili, or Klingon.

Nb. Ideally the name of the built-in administrator user should be replaced by a SID too, especially given that in addition to language dependency that name can be changed by a certain Group Policy setting. Unfortunately that one is more tricky because its well-known SID is not fully static and I don't know if Puppet can be told to match user as S-1-5--500. On the other hand, I have yet to see this particular bit of puppet-msoffice fail even though the built-in administrator account isn't called Administrator on any of the machines I work with - so maybe Puppet handles this one internally.

<!--
Thank you for contributing to this project!

-->