Add the ability to manage the user and group for nrpe. By default, this is turned off, but can easily be turned on if the user or group were not added automatically by the package.
Fix incorrect template data-type and add tests.
Some Gentoo derivative systems use amd64 instead of x86_64 for the
os.architecture fact. These systems need libdir to be set to /usr/lib64
and not /usr/lib as would otherwise be detected
allow_bash_command_substitution to be set.
config manifest sets the value to a string of 0 or 1, but the template expects a Boolean. Since we need to allow for undef value, best to keep it Boolean all the way through.
Error: Evaluation Error: Error while evaluating a Function Call, lambda: parameter 'allow_bash_command_substitution' expects a value of type Undef or Boolean, got String (file: /etc/puppetlabs/code/environments/nrpe_update/modules/nrpe/manifests/config.pp, line: 24, column: 16) on node localhost.localdomain
This PR splits the
manage_package parameters into two extra pairs of parameters, one for the daemon and one for the plugins. This allows more granular control of the deployments. In the use case of "the puppet module controls the daemon package but not the plugins package", without this PR you must replicate much of the os-based choices of
manifests/params.pp outside of the module in order to ensure that you get the right package names, when a much cleaner path is to simply capture that information in the module itself.
This is somewhat clumsy in that it introduces a duplication in the API, where you could end up with two different code paths controlling the same packages, so I'm quite open to changing patch 2 to be 'better' in terms of what's enabled/disabled, or if
manage_package is changed to false in preparation for deprecation, or whatever seems most sane.
The syslogfacility type is present in stdlib, so we should use it.
Before merging this,
https://github.com/puppetlabs/puppetlabs-stdlib/pull/1005 needs to be
released. We also need to update metadata.json
Thank you for contributing to this project!
Replace this comment with a description of your pull request.
Replace this comment with the list of issues or n/a.