GitHub puppet-nrpe
2
2
7
Puppet module for NRPE

Metadata Valid
No translation
Correct Puppet Version Range
Supported Puppet version range is %{PUPPET_VERSION_RANGE}
With Puppet Version Range
Puppet version range is present in requirements in metadata.json
With Operatingsystem Support
No translation
Supports Only Current Centos
No translation
Supports Latest Centos
No translation
Supports Only Current Debian
No translation
Supports Latest Debian
No translation
Supports Only Current Ubuntu
No translation
Supports Latest Ubuntu
No translation
In Modulesync Repo
No translation
In Plumbing
Is in plumbing
Has Secrets
Has a .sync.yml file
Synced
Has a .msync.yml file
Latest Modulesync
No translation
Has Modulesync
Is present in voxpupuli/modulesync_config/managed_modules.yml
Released
Is in modulesync_config and in forge releases.
Reference Dot Md
The repository has a REFERENCE.md. It needs to be generated / puppet-strings documentation is missing.

Open Pull Requests

release 4.0.0
skip-changelog

<!--
Thank you for contributing to this project!

-->

Pull Request (PR) description

<!--
Replace this comment with a description of your pull request.
-->

This Pull Request (PR) fixes the following issues

<!--
Replace this comment with the list of issues or n/a.
Use format:
Fixes #123
Fixes #124
-->

Split package management into daemon and plugins components
tests-fail
needs-tests

Pull Request (PR) description

This PR splits the package_name and manage_package parameters into two extra pairs of parameters, one for the daemon and one for the plugins. This allows more granular control of the deployments. In the use case of "the puppet module controls the daemon package but not the plugins package", without this PR you must replicate much of the os-based choices of manifests/params.pp outside of the module in order to ensure that you get the right package names, when a much cleaner path is to simply capture that information in the module itself.

This is somewhat clumsy in that it introduces a duplication in the API, where you could end up with two different code paths controlling the same packages, so I'm quite open to changing patch 2 to be 'better' in terms of what's enabled/disabled, or if manage_package is changed to false in preparation for deprecation, or whatever seems most sane.

Nrpe::Syslogfacility -> Stdlib::Syslogfacility
tests-fail

The syslogfacility type is present in stdlib, so we should use it.
Before merging this,
https://github.com/puppetlabs/puppetlabs-stdlib/pull/1005 needs to be
released. We also need to update metadata.json

<!--
Thank you for contributing to this project!

-->

Pull Request (PR) description

<!--
Replace this comment with a description of your pull request.
-->

This Pull Request (PR) fixes the following issues

<!--
Replace this comment with the list of issues or n/a.
Use format:
Fixes #123
Fixes #124
-->

Fix for allow_bash_command_substitution

Pull Request (PR) description

Allow allow_bash_command_substitution to be set.

This Pull Request (PR) fixes the following issues

config manifest sets the value to a string of 0 or 1, but the template expects a Boolean. Since we need to allow for undef value, best to keep it Boolean all the way through.

Error: Evaluation Error: Error while evaluating a Function Call, lambda: parameter 'allow_bash_command_substitution' expects a value of type Undef or Boolean, got String (file: /etc/puppetlabs/code/environments/nrpe_update/modules/nrpe/manifests/config.pp, line: 24, column: 16) on node localhost.localdomain

Fix for allow_bash_command_substitution
tests-fail
tests-fail

Pull Request (PR) description

Allow allow_bash_command_substitution to be set.

This Pull Request (PR) fixes the following issues

config manifest sets the value to a string of 0 or 1, but the template expects a Boolean. Since we need to allow for undef value, best to keep it Boolean all the way through.

Error: Evaluation Error: Error while evaluating a Function Call, lambda: parameter 'allow_bash_command_substitution' expects a value of type Undef or Boolean, got String (file: /etc/puppetlabs/code/environments/nrpe_update/modules/nrpe/manifests/config.pp, line: 24, column: 16) on node localhost.localdomain

Fix `allow_bash_command_substitution`
tests-fail
tests-fail
bug

Fix incorrect template data-type and add tests.

Fix Gentoo tests
tests-fail
merge-conflicts