I wanted to contribute back the info I got from #586 and I think this should do it :)

Pull Request (PR) description

Update readme with more info on using the Ondřej PPAs.

This Pull Request (PR) fixes the following issues

N/A

Pull Request (PR) description

Identify whether PHP extension apcu installation is idempotent

This Pull Request (PR) fixes the following issues

548

Fixes #603

Pull Request (PR) description

Allows for other versions of Remi's PHP

Pull Request (PR) description

Enhance acceptance tests

This Pull Request (PR) fixes the following issues

(TODO)

<!--
Thank you for contributing to this project!

• This project has a Contributor Code of Conduct: https://voxpupuli.org/coc/
• Please check that here is no existing issue or PR that addresses your problem.
• Our vulnerabilities reporting process is at https://voxpupuli.org/security/

-->

Pull Request (PR) description

<!--
Replace this comment with a description of your pull request.
-->
Download stable version of composer as opposed to snapshot

This Pull Request (PR) fixes the following issues

<!--
Replace this comment with the list of issues or n/a.
Use format:
Fixes #123
Fixes #124
-->
Fixes #575

Pull Request (PR) description

This PR adds validation check for fpm and fpm pools configuration file before applying changes.

Having introduced a misconfiguration on php-fpm that avoid the service to start normally (pm.start_servers > pm.max_spare_servers), catalog application was successfull but service failed to restart.


[13-Feb-2020 20:48:24] ALERT: [pool www] pm.start_servers(80) must not be less than pm.min_spare_servers(24) and not greater than pm.max_spare_servers(64)
[13-Feb-2020 20:48:24] ERROR: failed to post process the configuration


<!--
Thank you for contributing to this project!

• This project has a Contributor Code of Conduct: https://voxpupuli.org/coc/
• Please check that here is no existing issue or PR that addresses your problem.
• Our vulnerabilities reporting process is at https://voxpupuli.org/security/

-->

Pull Request (PR) description

Allow sury repo for PHP >= 7.1.

This Pull Request (PR) fixes the following issues

<!--
Replace this comment with the list of issues or n/a.
Use format:
Fixes #123
Fixes #124
-->

Pull Request (PR) description

Identify whether PHP extension xmlwriter installation is idempotent

This Pull Request (PR) fixes the following issues

548

Pull Request (PR) description

Identify whether PHP extension posix installation is idempotent

This Pull Request (PR) fixes the following issues

548

Pull Request (PR) description

Identify whether PHP extension imagick installation is idempotent

This Pull Request (PR) fixes the following issues

548

Pull Request (PR) description

Identify whether PHP extension iconv installation is idempotent

This Pull Request (PR) fixes the following issues

548

Pull Request (PR) description

Identify whether PHP extension dom installation is idempotent

This Pull Request (PR) fixes the following issues

548

Pull Request (PR) description

Identify whether PHP extension ctype installation is idempotent

This Pull Request (PR) fixes the following issues

548

Pull Request (PR) description

Identify whether PHP extension xmlreader installation is idempotent

This Pull Request (PR) fixes the following issues

548

Pull Request (PR) description

This PR prevents the creation of the hardcoded pid file directory if it is not used.

This Pull Request (PR) fixes the following issues

Fixes #501

Pull Request (PR) description

Allow configuration files to be purged.

This Pull Request (PR) fixes the following issues

Not directly releated but similar to https://github.com/voxpupuli/puppet-php/issues/237
No existing issue was created, we had a need for this functionality so we added it to our fork. Looking to contribute it back.

Pull Request (PR) description

Adding the option to set process.dumpable

This Pull Request (PR) fixes the following issues

If process.dumpable is disabled core dumps cannot be captured on segfaults even if rlimit_core is set because of the following change to PHP:

https://github.com/php/php-src/commit/276d19feaa43e6f77eeac59fc9e2639bee4d116b#diff-10cc4db817271640849c40a7fc1f0569

<!--
Thank you for contributing to this project!

• This project has a Contributor Code of Conduct: https://voxpupuli.org/coc/
• Please check that here is no existing issue or PR that addresses your problem.
• Our vulnerabilities reporting process is at https://voxpupuli.org/security/

-->

Pull Request (PR) description

<!--
Adding php 7 support for RHEL variants via remi repositories.

PHP version can now be defined using the global php_version variable for RHEL variants.

Support for PHP 7.0, 7.1 and 7.2 added.

-->

This Pull Request (PR) fixes the following issues

<!--
Replace this comment with the list of issues or n/a.
Use format:
Fixes #123
Fixes #124
-->

Pull Request (PR) description

If php::settings are changed and Apaches mod_php is used the Apache httpd must be restarted to re-read the config files.

This PR adds an option to identify the name of the Puppet Service resource to enable a restart of Apache httpd.

<!--
Thank you for contributing to this project!

• This project has a Contributor Code of Conduct: https://voxpupuli.org/coc/
• Please check that here is no existing issue or PR that addresses your problem.
• Our vulnerabilities reporting process is at https://voxpupuli.org/security/

-->

based upon https://github.com/voxpupuli/puppet-php/pull/322

Following https://github.com/puppetlabs/puppetlabs-apache/pull/1749#issuecomment-358125758, I adapted to puppet-php.
For now it is just part of settings, not sure if it should be differentiated.
Risk: users silently overwriting it vs potential post-adaption needed

Potentially more settings to add.

This fixes the pecl provider autoloading the pear provider. On Puppet 4.9.4, I get the following error:

Puppet::Error:
Could not autoload puppet/type/package: Could not autoload puppet/provider/package/pecl: cannot load such file -- puppet/provider/pear


It doesn't seem to happen on Puppet 3. This is fixed by requiring pear explicitly in the pecl provider code.

See https://github.com/voxpupuli/puppet-php/issues/581

In short, replaces all explicit definitions of a Puppet Package resource
with an instance of puppetlabs-stdlib's ensure_packages.

<!--
Thank you for contributing to this project!

• This project has a Contributor Code of Conduct: https://voxpupuli.org/coc/
• Please check that here is no existing issue or PR that addresses your problem.
• Our vulnerabilities reporting process is at https://voxpupuli.org/security/

-->

Pull Request (PR) description

Use the puppetlabs-stdlib ensure_packages function instead of Puppet package {} resources directly to avoid conflicting with other definitions of the package.

This Pull Request (PR) fixes the following issues

Fixes #581

Pull Request (PR) description

• Cleans up and fixes version handling when installing PHP using the remi repo on CentOS/RHEL. Tested on CentOS 7.
• Also adds beaker-vagrant to gemfile (see details in commit message for why)

Note: This changes the default version string of $php::globals::globals_php_version from 5.x to 5.6 on non-Debian/Ubuntu because we really should use sane version strings in such variables so we can re-use them elsewhere (like in php::repo::redhat for remi repo). I anticipate the versioning in php::globals will be cleaned up eventually. (I'll volunteer too.) It doesn't look like this change will have any adverse effects.

If merged, this PR obsoletes the following PRs: (Sorry, I'm impatient and they don't look like they're going anywhere)
- https://github.com/voxpupuli/puppet-php/pull/495
- https://github.com/voxpupuli/puppet-php/pull/509

This Pull Request (PR) fixes the following issues

Fixes #480

We noticed that your Puppet module includes Puppet 3.x function(s) and created
this pull request to help you get started porting them to the new API.

The Puppet function API has a long history and many people in the ecosystem,
including you, took advantage of this API to extend Puppet to do some really
cool things. Unfortunately the original function API had many critical
limitations, and so Puppet introduced a new and improved API with Puppet 4.x.

Each modern Puppet 4.x function is just a little faster and just a little safer
to use, meaning that as we all port our functions over, compilation times across
the ecosystem will get more and more performant. Modern Puppet 4.x functions
have improved thread safety, memory management, and load time. Even more
importantly, they’re isolated to the environment they’re loaded from.

And as a developer, you'll see benefits like namespaced function signatures,
automatic data type checking, multiple dispatches allowing you to easily handle
different kinds of function invocations, and vastly improved code reuse.

This pull request was autogenerated and the ported functions do not yet take
advantage of the data type checking or multiple dispatches. You will want to
finish the port by making those changes and adding any documentation updates.
See this tutorial for more information.

While you're at it, double check to see if there are any functions that couldn't
be automatically ported and update them yourself.

To be extra cautious about losing data, this pull request did NOT delete the
legacy function files, so when you're satisfied with the new functions, don't
forget to delete the legacy code!

If this repo is a fork, when you're all done, you might consider contributing
your work upstream.

If you have any questions, feel free to ping me in this PR, or stop by the
Puppet Community Slack to chat. And thanks so much
for being part of our vibrant community of developers!

Pull Request (PR) description

enable configuring 'listen.aclusers' and 'listen.aclgroups' by adding that option to pool template

This Pull Request (PR) fixes the following issues

Fixes #607

Follow-up on #611 implementing listen.? parameters as arrays instead of strings.

modulesync 5.1.0

Currently the class php::repo::redhat is hardcoded to create only the remi56 repo. This request removes that static value and creates based on $yumrepo. This allows for other versions such as remiphp72, etc..

Pull Request (PR) description

The code for php::config::setting permits passing Undef to force the ini_setting to be absent instead of present but the recent type change does not allow Undef. This simply adds Undef as a valid type.

This is necessary so that config settings can be removed (at least as a workaround for #653).

Pull Request (PR) description

Allows for PHP FPM pool settings to be configured as environment variables (pm_max_children => '${PM_MAX_CHILDREN}') in addition to their existing typed formats.

I debated about the best way to add this, and ended up adding Variant types, along with a single custom type. I did this because there were varying types (Integer[0], Integer[1], Php::Duration) that I didn't want to have to duplicate.

The env based configuration applies to every setting, but for right now I've added it to the most common ones where due to the stricter validation, it would previously fail.

This Pull Request (PR) fixes the following issues

Fixes #649