Vox Pupuli Tasks Repositories About
Log in

GitHub puppet-prometheus_reporter
A prometheus Puppet reports exporter for Puppet

Repo Checks ( 10 of 20 successfull )
Metadata Valid
No translation
passed
Correct Puppet Version Range
Supported Puppet version range is %{PUPPET_SUPPORT_RANGE}
passed
With Puppet Version Range
Puppet version range is present in requirements in metadata.json
passed
With Operatingsystem Support
No translation
passed
Operatingsystems
No translation
passed
Supports Only Current Redhat
No translation
failed
Supports Latest Redhat
No translation
failed
Supports Only Current Centos
No translation
failed
Supports Latest Centos
No translation
failed
Supports Only Current Debian
No translation
failed
Supports Latest Debian
No translation
failed
Supports Only Current Ubuntu
No translation
failed
Supports Latest Ubuntu
No translation
failed
In Modulesync Repo
Is listed as a module managed using modulesync_config
passed
Synced
Has a .msync.yml file
passed
Latest Modulesync
Has been synchronized with the latest tagged version of modulesync_config
failed
Has Modulesync
Is present in voxpupuli/modulesync_config/managed_modules.yml
passed
Released
Is in modulesync_config and in forge releases.
passed
Valid Sync File
If a (optional) sync file is present, it must not contain a `.travis.yml` entry.
passed
Reference Dot Md
The repository has a REFERENCE.md. It needs to be generated / puppet-strings documentation is missing.
failed

Open Pull Requests

reports: Update to use report_prefix

This commit removes the reportfilename config parameter and adds a reportprefix parameter. AFAICT the current code suggests that it will write all host data to the same file. However the code writes the old data to the prom file giving all values -1 which is incorrect

I looked at why this was and i can't find much information on the original issue[1] and PR[2]. further to this the current implementation is very racy if one sets REPORT_FILENAME

This also updates the clean stale function to only act on files with the report_prefix and avoid deleting files which may have been placed there by none puppetserver process

more then happy to split this up into separate patches but wanted to get a bit more feedback on why things got set to -1 and if im missing something

[1]https://github.com/voxpupuli/puppet-prometheus_reporter/pull/5 [2]https://github.com/voxpupuli/puppet-prometheus_reporter/pull/7

Open PR in GitHub