Pull Request (PR) description

This PR adds support to query just a single element of a secret, and return it as a Sensitive string. This makes it easier to pass a specific secret to another resource, as you don't have to deal with a hash of elements.

<!--
Thank you for contributing to this project!

• This project has a Contributor Code of Conduct: https://voxpupuli.org/coc/
• Please check that here is no existing issue or PR that addresses your problem.
• Our vulnerabilities reporting process is at https://voxpupuli.org/security/

-->

This Pull Request (PR) fixes the following issues

<!--
Fixes #7
-->

Pull Request (PR) description

The primary goal is to check CI status…

This Pull Request (PR) fixes the following issues

<!--
Replace this comment with the list of issues or n/a.
Use format:
Fixes #123
Fixes #124
-->

If a lookup function raises an exception, the whole catalog compilation will fail. This PR adds the ability to configure the lookup to not raise and instead simply log and return nil if it encounters an error, so that the users can structure their manifests to only conditionally depend on the result of the lookup.

We're not sure if this is useful or not, and are looking for use cases and feedback on the approach.

Fixes #13

Pull Request (PR) description

Adds path information for data lookup errors when needed

As of now when puppet fails to apply catalog vault_lookup returns message with no clue where error happens:

Error: Failed to apply catalog: Received 403 response code from vault at vault.local for secret lookup (api errors: ["1 error occurred:\n\t* permission denied\n\n"])

With proposed change you can see which lookup actually related to the problem:

Error: Failed to apply catalog: Received 403 response code from vault at vault.local for secret/data/puppet/service/graylog/s1/config lookup (api errors: ["1 error occurred:\n\t* permission denied\n\n"])

This PR adds support to use AppRole Vault's auth method.
It also adds support for configuring vault_lookup function using a configuration file as in https://github.com/voxpupuli/puppet-prometheus_reporter/blob/master/lib/puppet/reports/prometheus.rb#L12

The current implementation raises an exception if the lookup fails to resolve a result.... this just doesn't make sense for a data lookup, its more that conceivable that most of the time we will look up a value that might not exist.... raising an exception here means there is no way to handle this within Puppet and limits the usability of this function.

Instead of raising an exception, this PR changes the behaviour so that unresolved lookups return nil (Undef) and can therefore be handled within Puppet code.


$secret = vault_lookup('secret/data/no_exist')
if $secret {
$plantext = $secret.unwrap
}


Without this patch I fail to see how you can ever look up a value that doesn't exist, since it raises an exception and fails the Puppet run it becomes un-handlable.

Pull Request (PR) description

• Correction "undefined local variable or method `vaultroleid'"

This Pull Request (PR) fixes the following issues

• When i use the master branch code i have this exception - "undefined local variable or method `vaultroleid'"
• I think it's a omission during modification names vaultroleid to roleid and vaultsecretid to secretid

Description

This adds support for two new authentication methods when doing the Vault lookup.

agent:

add description...

agent_sink:

add description...

Issues Fixed

Fixes #7
Fixes #24

TODO

• [ ] spec tests
• [ ] Clarify that only unencrypted, non response-wrapped tokens are supported with agent_sink mode
• [ ] Fix readme typos I introduced last time: vault::vault_lookup() -> vault_lookup::lookup()

Description

This caches the result of a Vault lookup and uses that cached value for all subsequent lookups of the same path.
The caching implementation uses the cache_param feature of the 4.x Function API added here: https://tickets.puppetlabs.com/browse/PUP-8676

An example of why this cache is needed can be seen with this bit of Puppet code:
```puppet
$data = Deferred('vault_lookup::lookup', ['foo', 'https://vault.corp.net:8200'])

notify { 'message1':
message => $data,
}

notify { 'message2':
message => $data,
}
```

Before this change, the lookup for foo would be done twice per catalog application due to the two notify resources evaluating the Deferred type.

After this change, the lookup is done only once per catalog application.

TODO

• [ ] spec tests
• [ ] Cache the lookup based on all options used for the lookup. Currently it's only cached based on path.